Devices that are working quite well get lost in the big matrix of booting devices. To improve the situation, devices postmarketOS runs have been grouped into the following categories.
|main||yes, >= 2 people||Everything in community, plus required working device features (where available):
Not required (shall change in the future):
See also: postmarketos#25
Regarding device features (calls working, camera, ...), there is not a fixed feature set (so for users, don't assume that everything works, look at the device's wiki page for details).
The purpose of community is to increase visibility of devices that:
See also: postmarketos#24
|testing||no||All other device ports, including new ones. Maintainers can create merge requests to move devices to community if requirements are met.|
|unmaintained||no||Device ports that are broken or intentionally unmaintained (e.g. because better alternatives exist).
See also: pmaports!1912
A device maintainer must own the device and be able to test changes. They must make sure that the device port stays in good shape.
Moving between categories
Moving to a higher category
Moving from testing to community, from community to main or even from testing straight to main.
- Make sure that the device fulfills all requirements for the new category (see table above).
- Create a new merge request in which you move the files.
- Add new maintainers to the device's APKBUILD in the merge request, if necessary.
- The core team collects approvals as usual, but requires four approvals (instead of the usual two).
- Everyone should be given the chance to look at the entire device port again, to identify issues/possible improvements. Therefore the MR should not be merged before a minimum time of one week passed.
- Clarification on the week: usually the MR should be in good shape when opened, and only minor fixups should need to be done before merging. If that is the case, then it is one week after the MR was opened. Otherwise, one week after there were the last significant changes.
- Reviewers should look at all files that were moved and add comments as necessary. (GitLab currently doesn't allow in-line comments for moved files gitlab#213446, so just add comments below the merge request.)
- Reviewers should verify that the device fulfills all requirements for the new category (see table above).
- Reviewers should pay special attention to consistency issues, as outlined in postmarketos#24.
- Consistency issues/possible improvements in the existing features (not missing features) should be discussed and ideally fixed before merge.
- Consistency changes that require lots of work should be documented as issues at least. (Let's not unnecessarily delay merge, that's annoying for everyone.)
Moving to a lower category
If rules to keep a device in a category are no longer fulfilled, we should create a merge request to move them to the now appropriate category. So far we did not come up with extra rules, so we would treat it just like any other merge request.