Device categorization

From postmarketOS
Jump to navigation Jump to search

Devices that are working quite well get lost in the big matrix of booting devices. To improve the situation, devices postmarketOS runs have been grouped into the following categories.

Categories

Category Actively maintained Description
main yes, >= 2 people Everything in community, plus required working device features (where available):
  • Usable phone UI (i.e. Plasma Mobile or Phosh)
  • Calls (incl. call audio with earpiece)
  • SMS
  • Mobile Data
  • WiFi
  • Audio (speaker, main microphone ; headset, headset microphone ; jack detection, headset buttons)
  • Battery charging
  • Bluetooth

Not required (shall change in the future):

  • Camera

See also: postmarketos#25

community yes Requirements:
  • must run a (close to) mainline kernel
  • must have firewall working (pmaports#1119)
  • (coming soon: all of them must have automatic kernel upgrade working (pmaports#1158))
  • maintainer(s) must take part in the workflow for new postmarketOS releases:
    • join the release party chat to coordinate the release
    • testing their device and related fixing issues, according to the timeline

Regarding device features (calls working, camera, ...), there is not a fixed feature set (so for users, don't assume that everything works, look at the device's wiki page for details).

The purpose of community is to increase visibility of devices that:

  • a lot of work was put into
  • are (and stay) working quite well (i.e. they are useful in some way and are tested occasionally to find and fix regressions)
  • are still being improved or are considered completed at some point
  • are (and stay) overall in good shape

See also: postmarketos#24

testing no All other device ports, including new ones. Maintainers can create merge requests to move devices to community if requirements are met.
unmaintained no Device ports that are broken or intentionally unmaintained (e.g. because better alternatives exist).
  • They do not show up in pmbootstrap init but can be manually selected by entering the device codename. A warning is displayed with the reason why they are unmaintained.
  • Devices ports that are not functional (i.e. the device does not boot anymore) should be moved here if there is no active maintainer around to test/fix it.

See also: pmaports!1912

Maintainers

A device maintainer must own the device and be able to test changes. They must make sure that the device port stays in good shape.

Moving between categories

Moving to a higher category

Moving from testing to community, from community to main or even from testing straight to main.

Request process

  • Make sure that the device fulfills all requirements for the new category (see table above).
  • Create a new merge request in which you move the files.
  • Add new maintainers to the device's APKBUILD in the merge request, if necessary.

Review process

  • The core team collects approvals as usual, but requires four approvals (instead of the usual two).
  • Everyone should be given the chance to look at the entire device port again, to identify issues/possible improvements. Therefore the MR should not be merged before a minimum time of one week passed.
    • Clarification on the week: usually the MR should be in good shape when opened, and only minor fixups should need to be done before merging. If that is the case, then it is one week after the MR was opened. Otherwise, one week after there were the last significant changes.
  • Reviewers should look at all files that were moved and add comments as necessary. (GitLab currently doesn't allow in-line comments for moved files gitlab#213446, so just add comments below the merge request.)
  • Reviewers should verify that the device fulfills all requirements for the new category (see table above).
  • Reviewers should pay special attention to consistency issues, as outlined in postmarketos#24.
  • Consistency issues/possible improvements in the existing features (not missing features) should be discussed and ideally fixed before merge.
    • Consistency changes that require lots of work should be documented as issues at least. (Let's not unnecessarily delay merge, that's annoying for everyone.)

Moving to a lower category

If rules to keep a device in a category are no longer fulfilled, we should create a merge request to move them to the now appropriate category. So far we did not come up with extra rules, so we would treat it just like any other merge request.

See also